Skip to content

[SQL] Cleaned up ConstantFolding slightly.#1430

Closed
rxin wants to merge 2 commits into
apache:masterfrom
rxin:sql-folding-rule
Closed

[SQL] Cleaned up ConstantFolding slightly.#1430
rxin wants to merge 2 commits into
apache:masterfrom
rxin:sql-folding-rule

Conversation

@rxin

@rxin rxin commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

Moved couple rules out of NullPropagation and added more comments.

@rxin
[SQL] Cleaned up ConstantFolding slightly.
7f8cf61 
Moved couple rules out of NullPropagation and added more comments.
@SparkQA

SparkQA commented Jul 16, 2014

Copy link
Copy Markdown

QA tests have started for PR 1430. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16714/consoleFull

@chenghao-intel

chenghao-intel commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

The code looks good to me.
I am thinking if we could merge the ConstantFolding & NullPropagation and make it transformExpressionsUp , since they kind of rely on each other, and people may always get confused when place a Null or Constant optimization.

@rxin

rxin commented Jul 16, 2014

Copy link
Copy Markdown
Contributor Author

See the discussion at #1428.

@SparkQA

SparkQA commented Jul 16, 2014

Copy link
Copy Markdown

QA results for PR 1430:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16714/consoleFull

@rxin

rxin commented Jul 16, 2014

Copy link
Copy Markdown
Contributor Author

Merging in master & branch-1.0.

@asfgit asfgit closed this in 1c5739f Jul 16, 2014
@rxin

rxin commented Jul 16, 2014

Copy link
Copy Markdown
Contributor Author

Actually only master. There is a conflict in branch-1.0 that I will leave it intact for now.

@rxin rxin deleted the sql-folding-rule branch July 16, 2014 18:06
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rxin @conviva-zz
[SQL] Cleaned up ConstantFolding slightly.
ac0a764 
Moved couple rules out of NullPropagation and added more comments.

Author: Reynold Xin <rxin@apache.org>

Closes apache#1430 from rxin/sql-folding-rule and squashes the following commits:

7f9a197 [Reynold Xin] Updated documentation for ConstantFolding.
7f8cf61 [Reynold Xin] [SQL] Cleaned up ConstantFolding slightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rxin @SparkQA @chenghao-intel