Skip to content

SPARK-2407: Added Parser of SQL SUBSTR()#1442

Closed
chutium wants to merge 7 commits into
apache:masterfrom
chutium:master
Closed

SPARK-2407: Added Parser of SQL SUBSTR()#1442
chutium wants to merge 7 commits into
apache:masterfrom
chutium:master

Conversation

@chutium

@chutium chutium commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

follow-up of #1359

@chutium chutium changed the title SPARK-2407: Added Parse of SQL SUBSTR() SPARK-2407: Added Parser of SQL SUBSTR() Jul 16, 2014
@AmplabJenkins

AmplabJenkins commented Jul 16, 2014

Copy link
Copy Markdown

Can one of the admins verify this patch?

@chutium chutium mentioned this pull request Jul 16, 2014
Closed
@willb

willb commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

That was my thought as well, @egraldlo. Thanks for submitting this, @chutium!

@egraldlo

egraldlo commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

thx @willb, maybe protected val SUBSTRING = Keyword("SUBSTRING") as well, but this will cause the code redundance.

@willb

willb commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

@egraldlo, couldn't it be (SUBSTR | SUBSTRING) ~> // ... in that case?

@egraldlo

egraldlo commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

fine, that's great!

@marmbrus

marmbrus commented Jul 16, 2014

Copy link
Copy Markdown
Contributor

Please add a test to SQLQuerySuite

@chutium

chutium commented Jul 17, 2014

Copy link
Copy Markdown
Contributor Author

added a simple test in SQLQuerySuite

@chutium

chutium commented Jul 18, 2014

Copy link
Copy Markdown
Contributor Author

and... how can i run a single test class using maven? i tried:
mvn -Pyarn -Phive -Dhadoop.version=2.3.0-cdh5.0.3 -Dtest=SQLQuerySuite test
but it does not work

@marmbrus

marmbrus commented Jul 18, 2014

Copy link
Copy Markdown
Contributor

I don't know how do it with maven but with sbt:

sbt/sbt "sql/test-only org.apache.spark.sql.SQLQuerySuite"

@chutium

chutium commented Jul 18, 2014

Copy link
Copy Markdown
Contributor Author

@egraldlo @willb thanks guys, substring is also added, @marmbrus test also done and passed.

@marmbrus

marmbrus commented Jul 18, 2014

Copy link
Copy Markdown
Contributor

test this please

@SparkQA

SparkQA commented Jul 18, 2014

Copy link
Copy Markdown

QA tests have started for PR 1442. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16834/consoleFull

@SparkQA

SparkQA commented Jul 18, 2014

Copy link
Copy Markdown

QA results for PR 1442:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16834/consoleFull

@marmbrus

marmbrus commented Jul 19, 2014

Copy link
Copy Markdown
Contributor

Thanks! I've merged this into master.

@asfgit asfgit closed this in 2a73211 Jul 19, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@chutium @conviva-zz
SPARK-2407: Added Parser of SQL SUBSTR()
ba3811f 
follow-up of apache#1359

Author: chutium <teng.qiu@gmail.com>

Closes apache#1442 from chutium/master and squashes the following commits:

b49cc8a [chutium] SPARK-2407: Added Parser of SQL SUBSTRING() apache#1442
9a60ccf [chutium] SPARK-2407: Added Parser of SQL SUBSTR() apache#1442
06e933b [chutium] Merge https://github.com/apache/spark
c870172 [chutium] Merge https://github.com/apache/spark
094f773 [chutium] Merge https://github.com/apache/spark
88cb37d [chutium] Merge https://github.com/apache/spark
1de83a7 [chutium] SPARK-2407: Added Parse of SQL SUBSTR()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chutium @AmplabJenkins @willb @egraldlo @marmbrus @SparkQA