Skip to content

Revert "[SPARK-17704][ML][MLLIB] ChiSqSelector performance improvement."#15298

Closed
yanboliang wants to merge 1 commit into
apache:masterfrom
yanboliang:revert-17704
Closed

Revert "[SPARK-17704][ML][MLLIB] ChiSqSelector performance improvement."#15298
yanboliang wants to merge 1 commit into
apache:masterfrom
yanboliang:revert-17704

Conversation

@yanboliang

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Revert "[SPARK-17704][ML][MLLIB] ChiSqSelector performance improvement."
This reverts commit f7082ac.

How was this patch tested?

@srowen

srowen commented Sep 29, 2016

Copy link
Copy Markdown
Member

Yes that's fine, note you can also just revert the PR and push that commit straight to the apache git remote if you want to.

@yanboliang

Copy link
Copy Markdown
Contributor Author

@srowen Sure. Thanks.

@srowen

srowen commented Sep 29, 2016

Copy link
Copy Markdown
Member

OK instead of reverting this, maybe it's easier to just consider an additional change. What do you think of #15299?

@yanboliang

Copy link
Copy Markdown
Contributor Author

OK, I'll close this one and move to #15299 . Thanks.

@yanboliang yanboliang closed this Sep 29, 2016
@yanboliang yanboliang deleted the revert-17704 branch September 29, 2016 13:52
@SparkQA

SparkQA commented Sep 29, 2016

Copy link
Copy Markdown

Test build #66098 has finished for PR 15298 at commit e034f8b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants