[SPARK-17671] [WEBUI] Spark 2.0 history server summary page is slow even set spark.history.ui.maxApplications#15321
Closed
srowen wants to merge 4 commits into
Closed
[SPARK-17671] [WEBUI] Spark 2.0 history server summary page is slow even set spark.history.ui.maxApplications#15321srowen wants to merge 4 commits into
srowen wants to merge 4 commits into
Conversation
…sistency and performance
Member
Author
|
CC @wgtmac and @ajbozarth for a look, in case I'm missing something. |
|
Test build #66230 has finished for PR 15321 at commit
|
Member
|
LGTM |
Member
|
Looks like some tests need to be updated, but what's here LGTM |
|
Test build #66242 has finished for PR 15321 at commit
|
|
Test build #66243 has finished for PR 15321 at commit
|
Member
|
LGTM |
|
Test build #66245 has finished for PR 15321 at commit
|
Member
Author
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Return Iterator of applications internally in history server, for consistency and performance. See #15248 for some back-story.
The code called by and calling HistoryServer.getApplicationList wants an Iterator, but this method materializes an Iterable, which potentially causes a performance problem. It's simpler too to make this internal method also pass through an Iterator.
How was this patch tested?
Existing tests.