[SPARK-17346][SQL][Tests]Fix the flaky topic deletion in KafkaSourceStressSuite#15384
[SPARK-17346][SQL][Tests]Fix the flaky topic deletion in KafkaSourceStressSuite#15384zsxwing wants to merge 3 commits into
Conversation
|
/cc @tdas |
srowen
left a comment
There was a problem hiding this comment.
Yes we shouldn't be deleting that topic
|
Test build #66466 has finished for PR 15384 at commit
|
|
Are you sure we are ignoring all internal topics with that filter? |
Good point. Just use |
|
Test build #66471 has finished for PR 15384 at commit
|
|
LGTM. Merging it to master and 2.0 |
|
Correction. Merging to master only. Can you fix the 2.0 PR with this issue since that is still open? |
… shut down the Kafka cluster
|
Since deleting a normal topic may be timeout as well: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6/1763/testReport/junit/org.apache.spark.sql.kafka010/KafkaSourceStressSuite/_It_is_not_a_test_/ I just removed the topic deletion codes. It's not necessary since we are going to shut down the kafka cluster. |
|
Test build #66520 has finished for PR 15384 at commit
|
|
@tdas since this one has not yet been merged, I just updated the PR to remove the topic cleanup. |
|
Merging it to master, and branch 2.0 |
…StressSuite ## What changes were proposed in this pull request? A follow up Pr for SPARK-17346 to fix flaky `org.apache.spark.sql.kafka010.KafkaSourceStressSuite`. Test log: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.4/1855/testReport/junit/org.apache.spark.sql.kafka010/KafkaSourceStressSuite/_It_is_not_a_test_/ Looks like deleting the Kafka internal topic `__consumer_offsets` is flaky. This PR just simply ignores internal topics. ## How was this patch tested? Existing tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes #15384 from zsxwing/SPARK-17346-flaky-test. (cherry picked from commit 75b9e35) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
…StressSuite ## What changes were proposed in this pull request? A follow up Pr for SPARK-17346 to fix flaky `org.apache.spark.sql.kafka010.KafkaSourceStressSuite`. Test log: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.4/1855/testReport/junit/org.apache.spark.sql.kafka010/KafkaSourceStressSuite/_It_is_not_a_test_/ Looks like deleting the Kafka internal topic `__consumer_offsets` is flaky. This PR just simply ignores internal topics. ## How was this patch tested? Existing tests. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#15384 from zsxwing/SPARK-17346-flaky-test.
What changes were proposed in this pull request?
A follow up Pr for SPARK-17346 to fix flaky
org.apache.spark.sql.kafka010.KafkaSourceStressSuite.Test log: https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.4/1855/testReport/junit/org.apache.spark.sql.kafka010/KafkaSourceStressSuite/_It_is_not_a_test_/
Looks like deleting the Kafka internal topic
__consumer_offsetsis flaky. This PR just simply ignores internal topics.How was this patch tested?
Existing tests.