[SPARK-18114][MESOS] Fix mesos cluster scheduler generate command option error#15643
Closed
dalei-wang wants to merge 1 commit into
Closed
[SPARK-18114][MESOS] Fix mesos cluster scheduler generate command option error#15643dalei-wang wants to merge 1 commit into
dalei-wang wants to merge 1 commit into
Conversation
…ue should enclosed by ""
dalei-wang
changed the title
|
@srowen LGTM. Can we get this in 2.0 and master? (and 1.6 if that's still supported) |
|
Test build #3389 has finished for PR 15643 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 1, 2016
…ion error Enclose --conf option value with "" to support multi value configs like spark.driver.extraJavaOptions, without "", driver will fail to start. Jenkins Tests. Test in our production environment, also unit tests, It is a very small change. Author: Wang Lei <lei.wang@kongming-inc.com> Closes #15643 from LeightonWong/messos-cluster. (cherry picked from commit 9b377aa) Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
|
Merged to master/2.0. It didn't merge cleanly vs 1.6, not in a way I could resolve with confidence. |
dalei-wang
changed the title
Author
|
Let's just leave it. Thanks! |
Contributor
|
@srowen this broke the build in branch-2.0. |
Member
|
Gah, let me go see what happened there and fix it @rxin. It looked clean enough to cherry pick but I must have missed something |
Member
|
Ugh, the line became just a bit too long. HOTFIXing it straight away ... |
asfgit
pushed a commit
that referenced
this pull request
Nov 1, 2016
…PARK-18114 ## What changes were proposed in this pull request? Fix style error introduced in cherry-pick of #15643 to branch-2.0. ## How was this patch tested? Existing tests Author: Sean Owen <sowen@cloudera.com> Closes #15719 from srowen/SPARK-18114.2.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…ion error ## What changes were proposed in this pull request? Enclose --conf option value with "" to support multi value configs like spark.driver.extraJavaOptions, without "", driver will fail to start. ## How was this patch tested? Jenkins Tests. Test in our production environment, also unit tests, It is a very small change. Author: Wang Lei <lei.wang@kongming-inc.com> Closes apache#15643 from LeightonWong/messos-cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enclose --conf option value with "" to support multi value configs like spark.driver.extraJavaOptions, without "", driver will fail to start.
How was this patch tested?
Jenkins Tests.
Test in our production environment, also unit tests, It is a very small change.