Skip to content

[SPARK-2580] [PySpark] keep silent in worker if JVM close the socket#1625

Closed
davies wants to merge 2 commits into
apache:masterfrom
davies:error
Closed

[SPARK-2580] [PySpark] keep silent in worker if JVM close the socket#1625
davies wants to merge 2 commits into
apache:masterfrom
davies:error

Conversation

@davies

@davies davies commented Jul 29, 2014

Copy link
Copy Markdown
Contributor

During rdd.take(n), JVM will close the socket if it had got enough data, the Python worker should keep silent in this case.

In the same time, the worker should not print the trackback into stderr if it send the traceback to JVM successfully.

@SparkQA

SparkQA commented Jul 29, 2014

Copy link
Copy Markdown

QA tests have started for PR 1625. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17321/consoleFull

@SparkQA

SparkQA commented Jul 29, 2014

Copy link
Copy Markdown

QA results for PR 1625:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17321/consoleFull

@rxin

rxin commented Jul 29, 2014

Copy link
Copy Markdown
Contributor

@JoshRosen

@SparkQA

SparkQA commented Jul 29, 2014

Copy link
Copy Markdown

QA tests have started for PR 1625. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17343/consoleFull

@JoshRosen

Copy link
Copy Markdown
Contributor

I've merged this into master and branch-1.0. Thanks Davies!

@davies

davies commented Jul 29, 2014

Copy link
Copy Markdown
Contributor Author

@JoshRosen did it include the last commit? I didn't find them in master nor branch-1.0. It's delayed?

@JoshRosen

Copy link
Copy Markdown
Contributor

@davies Yeah, it included both commits. If you check the Apache repo, you should see the commits, but the GitHub mirroring is currently lagging behind.

@SparkQA

SparkQA commented Jul 29, 2014

Copy link
Copy Markdown

QA results for PR 1625:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17343/consoleFull

@mattf

mattf commented Jul 29, 2014

Copy link
Copy Markdown

+1 lgtm, validated

@asfgit asfgit closed this in ccd5ab5 Jul 29, 2014
asfgit pushed a commit that referenced this pull request Jul 29, 2014
During rdd.take(n), JVM will close the socket if it had got enough data, the Python worker should keep silent in this case.

In the same time, the worker should not print the trackback into stderr if it send the traceback to JVM successfully.

Author: Davies Liu <davies.liu@gmail.com>

Closes #1625 from davies/error and squashes the following commits:

4fbcc6d [Davies Liu] disable log4j during testing when exception is expected.
cc14202 [Davies Liu] keep silent in worker if JVM close the socket

(cherry picked from commit ccd5ab5)
Signed-off-by: Josh Rosen <joshrosen@apache.org>
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
During rdd.take(n), JVM will close the socket if it had got enough data, the Python worker should keep silent in this case.

In the same time, the worker should not print the trackback into stderr if it send the traceback to JVM successfully.

Author: Davies Liu <davies.liu@gmail.com>

Closes apache#1625 from davies/error and squashes the following commits:

4fbcc6d [Davies Liu] disable log4j during testing when exception is expected.
cc14202 [Davies Liu] keep silent in worker if JVM close the socket
@davies davies deleted the error branch September 15, 2014 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants