Skip to content

[SPARK-19444][ML][Documentation] Fix imports not being present in documentation #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anshbansal wants to merge 2 commits into from
Closed

[SPARK-19444][ML][Documentation] Fix imports not being present in documentation #16789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb68cc0
Fix for SPARK-19444
anshbansal Feb 3, 2017
1d50a9d
Update JavaTokenizerExample.java
anshbansal Feb 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/src/main/java/org/apache/spark/examples/ml/JavaTokenizerExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,11 @@
import org.apache.spark.sql.types.Metadata;
import org.apache.spark.sql.types.StructField;
import org.apache.spark.sql.types.StructType;
// $example off$

// $example on:untyped_ops$
// col("...") is preferable to df.col("...")
import static org.apache.spark.sql.functions.callUDF;
import static org.apache.spark.sql.functions.col;
// $example off:untyped_ops$
// $example off

@gatorsmile gatorsmile Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses $

@srowen srowen Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS I actually fixed this in my big "Java 8" PR for SPARK-19550 because I needed to get the examples to compile. If we don't get that merged soon yes let's fix this in a quick PR

@gatorsmile gatorsmile Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit this issue when I tried to review a Documentation-related PR. Thus, I submitted the PR.


public class JavaTokenizerExample {
public static void main(String[] args) {
Expand Down