Skip to content

[SPARK-19604] [TESTS] Log the start of every Python test#16935

Closed
yhuai wants to merge 1 commit into
apache:masterfrom
yhuai:SPARK-19604
Closed

[SPARK-19604] [TESTS] Log the start of every Python test#16935
yhuai wants to merge 1 commit into
apache:masterfrom
yhuai:SPARK-19604

Conversation

@yhuai

@yhuai yhuai commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.

How was this patch tested?

This is a change for python tests.

… Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.
@SparkQA

SparkQA commented Feb 15, 2017

Copy link
Copy Markdown

Test build #72919 has finished for PR 16935 at commit 1181cc3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yhuai

yhuai commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

Let's not merge it right now. I may need to log more.

@yhuai

yhuai commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

ok. Nothing new to add. I will merge this to master and branch-2.1 (in case we want to debug any python test hanging issue in branch-2.1).

@liancheng

Copy link
Copy Markdown
Contributor

Merging to master an branch-2.1.

@yhuai

yhuai commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

Seems I cannot merge now... Will try again later.

@liancheng

Copy link
Copy Markdown
Contributor

Me neither...

@asfgit asfgit closed this in f6c3bba Feb 16, 2017
asfgit pushed a commit that referenced this pull request Feb 16, 2017
## What changes were proposed in this pull request?
Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.

## How was this patch tested?
This is a change for python tests.

Author: Yin Huai <yhuai@databricks.com>

Closes #16935 from yhuai/SPARK-19604.

(cherry picked from commit f6c3bba)
Signed-off-by: Yin Huai <yhuai@databricks.com>
@yhuai

yhuai commented Feb 16, 2017

Copy link
Copy Markdown
Contributor Author

cool. It has been merged.

cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 16, 2017
## What changes were proposed in this pull request?
Right now, we only have info level log after we finish the tests of a Python test file. We should also log the start of a test. So, if a test is hanging, we can tell which test file is running.

## How was this patch tested?
This is a change for python tests.

Author: Yin Huai <yhuai@databricks.com>

Closes apache#16935 from yhuai/SPARK-19604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants