[SPARK-19970][SQL][BRANCH-2.1] Table owner should be USER instead of PRINCIPAL in kerberized clusters#17363
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
[SPARK-19970][SQL][BRANCH-2.1] Table owner should be USER instead of PRINCIPAL in kerberized clusters#17363dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
…PRINCIPAL in kerberized clusters
dongjoon-hyun
commented
Mar 20, 2017
| } | ||
| hiveTable.setPartCols(partCols.asJava) | ||
| hiveTable.setOwner(conf.getUser) | ||
| hiveTable.setOwner(state.getAuthenticator().getUserName()) |
Member
Author
|
Test build #74891 has finished for PR 17363 at commit
|
Member
Author
|
This is also tested manually in kerberized cluster, @vanzin . BTW, Spark 1.6 has the same issue at ClientWrapper. According to the Spark dev email, there exists demands on more Apache Spark 1.6.X. May I create a backport for branch-1.6? How do you think about that? For Spark 1.6, it happens only with CREATE TABLE .. AS SELECT statement. |
Member
Author
|
Hi, @vanzin . |
Member
Author
|
Retest this please |
|
Test build #75055 has finished for PR 17363 at commit
|
Contributor
|
Merging to 2.1 / 2.0. I don't really expect any more 1.6 releases at this point, so I wouldn't bother. |
asfgit
pushed a commit
that referenced
this pull request
Mar 23, 2017
…PRINCIPAL in kerberized clusters ## What changes were proposed in this pull request? In the kerberized hadoop cluster, when Spark creates tables, the owner of tables are filled with PRINCIPAL strings instead of USER names. This is inconsistent with Hive and causes problems when using [ROLE](https://cwiki.apache.org/confluence/display/Hive/SQL+Standard+Based+Hive+Authorization) in Hive. We had better to fix this. **BEFORE** ```scala scala> sql("create table t(a int)").show scala> sql("desc formatted t").show(false) ... |Owner: |sparkEXAMPLE.COM | | ``` **AFTER** ```scala scala> sql("create table t(a int)").show scala> sql("desc formatted t").show(false) ... |Owner: |spark | | ``` ## How was this patch tested? Manually do `create table` and `desc formatted` because this happens in Kerberized clusters. Author: Dongjoon Hyun <dongjoon@apache.org> Closes #17363 from dongjoon-hyun/SPARK-19970-2.
Contributor
|
Failed to merge to 2.0. :-/ |
Contributor
|
@dongjoon-hyun you'll have to manually close this. |
Member
Author
|
Oo. Thank you so much, @vanzin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the kerberized hadoop cluster, when Spark creates tables, the owner of tables are filled with PRINCIPAL strings instead of USER names. This is inconsistent with Hive and causes problems when using ROLE in Hive. We had better to fix this.
BEFORE
AFTER
How was this patch tested?
Manually do
create tableanddesc formattedbecause this happens in Kerberized clusters.