Skip to content

[SPARK-23020][CORE][FOLLOWUP] Fix Java style check issues.#20376

Closed
ueshin wants to merge 1 commit into
apache:masterfrom
ueshin:issues/SPARK-23020/fup1
Closed

[SPARK-23020][CORE][FOLLOWUP] Fix Java style check issues.#20376
ueshin wants to merge 1 commit into
apache:masterfrom
ueshin:issues/SPARK-23020/fup1

Conversation

@ueshin

@ueshin ueshin commented Jan 24, 2018

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This is a follow-up of #20297 which broke lint-java checks.
This pr fixes the lint-java issues.

[ERROR] src/test/java/org/apache/spark/launcher/BaseSuite.java:[21,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
[ERROR] src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java:[27,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.

How was this patch tested?

Checked manually in my local environment.

@cloud-fan

cloud-fan commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

LGTM, cc @vanzin

dongjoon-hyun
dongjoon-hyun approved these changes Jan 24, 2018
View reviewed changes

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

viirya
viirya approved these changes Jan 24, 2018
View reviewed changes

@viirya viirya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA

SparkQA commented Jan 24, 2018

Copy link
Copy Markdown

Test build #86561 has finished for PR 20376 at commit dfd828b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

viirya commented Jan 24, 2018

Copy link
Copy Markdown
Member

retest this please.

@SparkQA

SparkQA commented Jan 24, 2018

Copy link
Copy Markdown

Test build #86574 has finished for PR 20376 at commit dfd828b.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

HyukjinKwon commented Jan 24, 2018

Copy link
Copy Markdown
Member

retest this please

1 similar comment
@HyukjinKwon

HyukjinKwon commented Jan 24, 2018

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented Jan 24, 2018

Copy link
Copy Markdown

Test build #86576 has finished for PR 20376 at commit dfd828b.

  • This patch fails from timeout after a configured wait of `300m`.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

kiszk commented Jan 24, 2018

Copy link
Copy Markdown
Member

Retest this please

@SparkQA

SparkQA commented Jan 24, 2018

Copy link
Copy Markdown

Test build #86584 has finished for PR 20376 at commit dfd828b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Jan 24, 2018

Copy link
Copy Markdown

Test build #86588 has finished for PR 20376 at commit dfd828b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin

vanzin commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

Merging to master / 2.3.

asfgit pushed a commit that referenced this pull request Jan 24, 2018
@ueshin
[SPARK-23020][CORE][FOLLOWUP] Fix Java style check issues.
2221a30 
## What changes were proposed in this pull request?

This is a follow-up of #20297 which broke lint-java checks.
This pr fixes the lint-java issues.

```
[ERROR] src/test/java/org/apache/spark/launcher/BaseSuite.java:[21,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
[ERROR] src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java:[27,8] (imports) UnusedImports: Unused import - java.util.concurrent.TimeUnit.
```

## How was this patch tested?

Checked manually in my local environment.

Author: Takuya UESHIN <ueshin@databricks.com>

Closes #20376 from ueshin/issues/SPARK-23020/fup1.

(cherry picked from commit 8c273b4)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@asfgit asfgit closed this in 8c273b4 Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes
@srowen srowen srowen approved these changes
@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes
@felixcheung felixcheung felixcheung approved these changes
@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ueshin @cloud-fan @SparkQA @viirya @HyukjinKwon @kiszk @vanzin @srowen @felixcheung @dongjoon-hyun