Skip to content

[SPARK-3216] [SPARK-3232] Spark-shell is broken in branch-1.0 / Backport SPARK-3006 into branch-1.0#2136

Closed
sarutak wants to merge 4 commits into
apache:branch-1.0from
sarutak:SPARK-3216
Closed

[SPARK-3216] [SPARK-3232] Spark-shell is broken in branch-1.0 / Backport SPARK-3006 into branch-1.0#2136
sarutak wants to merge 4 commits into
apache:branch-1.0from
sarutak:SPARK-3216

Conversation

@sarutak

@sarutak sarutak commented Aug 26, 2014

Copy link
Copy Markdown
Member

No description provided.

@sarutak

sarutak commented Aug 26, 2014

Copy link
Copy Markdown
Member Author

Jenkins, test this please.

@sarutak

sarutak commented Aug 26, 2014

Copy link
Copy Markdown
Member Author

@andrewor14 I also tried but couldn't let Jenkins work...

andrewor14
andrewor14 reviewed Aug 26, 2014
View reviewed changes
Comment thread bin/spark-shell.cmd

@andrewor14 andrewor14 Aug 26, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't actually work. You need to put the %* before spark-shell

@andrewor14

andrewor14 commented Aug 26, 2014

Copy link
Copy Markdown
Contributor

@sarutak Good catch on including #1918 as well. I will close my PR in favor of this.

@andrewor14 andrewor14 mentioned this pull request Aug 26, 2014
Closed
@pwendell

pwendell commented Aug 26, 2014

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@sarutak

sarutak commented Aug 27, 2014

Copy link
Copy Markdown
Member Author

Test would not start...

/CC @andrewor14 @pwendell

@JoshRosen

JoshRosen commented Aug 28, 2014

Copy link
Copy Markdown
Contributor

Jenkins, retest this please.

@sarutak

sarutak commented Sep 2, 2014

Copy link
Copy Markdown
Member Author

Jenkins, retest this please.

@shivaram

shivaram commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

Jenkins, retest this please

@shivaram

shivaram commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

Does anybody know why Jenkins won't pick this up ? Its annoying that we can't use spark-shell from branch-1.0

@shivaram

shivaram commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

I figured out why Jenkins doesn't work. It looks for dev/run-tests-jenkins which isn't there in branch-1.0
@pwendell any ideas on how we can test back ports to branch-1.0 ?

@andrewor14

andrewor14 commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

@pwendell just fixed it on our side. Now it goes and fetches dev/run-tests-jenkins if it doesn't exist.

Jenkins, test this please.

@shivaram

shivaram commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

Jenkins, retest this please

@SparkQA

SparkQA commented Sep 3, 2014

Copy link
Copy Markdown

QA tests have started for PR 2136 at commit 5c20d2d.

  • This patch merges cleanly.

@SparkQA

SparkQA commented Sep 3, 2014

Copy link
Copy Markdown

QA tests have finished for PR 2136 at commit 5c20d2d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@shivaram

shivaram commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

@andrewor14 Is this good to merge ? Or are there any comments that haven't been addressed ?

@andrewor14

andrewor14 commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

Yeah but I'll just fix it up myself. Thanks @sarutak I've merged this. Mind closing this issue? @asfgit won't do it for some reason.

@shivaram

shivaram commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

Thanks @andrewor14 !

asfgit pushed a commit that referenced this pull request Sep 3, 2014
@sarutak @andrewor14
[SPARK-3216] [SPARK-3232] Spark-shell is broken in branch-1.0 / Backp…
8dd7690 
…ort SPARK-3006 into branch-1.0

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Author: Andrew Or <andrewor14@gmail.com>

Closes #2136 from sarutak/SPARK-3216 and squashes the following commits:

5c20d2d [Kousuke Saruta] Merge branch 'branch-1.0' of git://git.apache.org/spark into SPARK-3216
af0517f [Kousuke Saruta] Modified spark-shell.cmd, backporting SPARK-3006
bbc7221 [Kousuke Saruta] Replace 4-space into 2-space
15cd980 [Andrew Or] Fix spark-shell in branch-1.0
@JoshRosen

JoshRosen commented Sep 3, 2014

Copy link
Copy Markdown
Contributor

GitHub won't close pull requests from commit messages unless those commits are merged into master.

@sarutak

sarutak commented Sep 4, 2014

Copy link
Copy Markdown
Member Author

May I close this PR manually?

@JoshRosen

JoshRosen commented Sep 4, 2014

Copy link
Copy Markdown
Contributor

Yes, please go ahead and close it, now that Andrew has merged your patch. Thanks!

@sarutak sarutak closed this Sep 4, 2014
@sarutak sarutak deleted the SPARK-3216 branch April 11, 2015 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sarutak @andrewor14 @pwendell @JoshRosen @shivaram @SparkQA