[SPARK-25431][SQL][EXAMPLES] Fix function examples and the example results.#22437
Closed
ueshin wants to merge 2 commits into
Closed
[SPARK-25431][SQL][EXAMPLES] Fix function examples and the example results.#22437ueshin wants to merge 2 commits into
ueshin wants to merge 2 commits into
Conversation
Member
Author
|
Test build #96118 has finished for PR 22437 at commit
|
|
Test build #96117 has finished for PR 22437 at commit
|
Member
Author
|
Jenkins, retest this please. |
|
Test build #96122 has finished for PR 22437 at commit
|
Member
Author
|
Jenkins, retest this please. |
dongjoon-hyun
approved these changes
Sep 17, 2018
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM.
I also did double-check manually. Thank you, @ueshin .
|
Test build #96127 has finished for PR 22437 at commit
|
Member
|
Merged to master and branch-2.4. |
asfgit
pushed a commit
that referenced
this pull request
Sep 17, 2018
…sults. ## What changes were proposed in this pull request? There are some mistakes in examples of newly added functions. Also the format of the example results are not unified. We should fix them. ## How was this patch tested? Manually executed the examples. Closes #22437 from ueshin/issues/SPARK-25431/fix_examples_2. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org> (cherry picked from commit 8cf6fd1) Signed-off-by: hyukjinkwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are some mistakes in examples of newly added functions. Also the format of the example results are not unified. We should fix them.
How was this patch tested?
Manually executed the examples.