Skip to content

[SPARK-26060][SQL][FOLLOW-UP] Rename the config name.#23245

Closed
ueshin wants to merge 3 commits into
apache:masterfrom
ueshin:issues/SPARK-26060/rename_config
Closed

[SPARK-26060][SQL][FOLLOW-UP] Rename the config name.#23245
ueshin wants to merge 3 commits into
apache:masterfrom
ueshin:issues/SPARK-26060/rename_config

Conversation

@ueshin

@ueshin ueshin commented Dec 6, 2018

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This is a follow-up of #23031 to rename the config name to spark.sql.legacy.setCommandRejectsSparkCoreConfs.

How was this patch tested?

Existing tests.

@ueshin

ueshin commented Dec 6, 2018

Copy link
Copy Markdown
Member Author

cc @cloud-fan

@SparkQA

SparkQA commented Dec 6, 2018

Copy link
Copy Markdown

Test build #99764 has finished for PR 23245 at commit 021134c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented Dec 6, 2018

Copy link
Copy Markdown

Test build #99768 has finished for PR 23245 at commit 021134c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Comment thread sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala Outdated
@SparkQA

SparkQA commented Dec 7, 2018

Copy link
Copy Markdown

Test build #99797 has finished for PR 23245 at commit 15000a2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented Dec 7, 2018

Copy link
Copy Markdown

Test build #99803 has finished for PR 23245 at commit 2e9b09c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ArrowCollectSerializer(Serializer):

@dongjoon-hyun

Copy link
Copy Markdown
Member

Retest this please.

@SparkQA

SparkQA commented Dec 7, 2018

Copy link
Copy Markdown

Test build #99809 has finished for PR 23245 at commit 2e9b09c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ArrowCollectSerializer(Serializer):

@ueshin

ueshin commented Dec 7, 2018

Copy link
Copy Markdown
Member Author

Jenkins, retest this please.

@SparkQA

SparkQA commented Dec 7, 2018

Copy link
Copy Markdown

Test build #99818 has finished for PR 23245 at commit 2e9b09c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class ArrowCollectSerializer(Serializer):

@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you all. Merged to master.

@asfgit asfgit closed this in 1ab3d3e Dec 7, 2018
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

This is a follow-up of apache#23031 to rename the config name to `spark.sql.legacy.setCommandRejectsSparkCoreConfs`.

## How was this patch tested?

Existing tests.

Closes apache#23245 from ueshin/issues/SPARK-26060/rename_config.

Authored-by: Takuya UESHIN <ueshin@databricks.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants