Skip to content

[SPARK-27687][SS] Rename Kafka consumer cache capacity conf and document caching#24590

Closed
gaborgsomogyi wants to merge 2 commits into
apache:masterfrom
gaborgsomogyi:SPARK-27687
Closed

[SPARK-27687][SS] Rename Kafka consumer cache capacity conf and document caching#24590
gaborgsomogyi wants to merge 2 commits into
apache:masterfrom
gaborgsomogyi:SPARK-27687

Conversation

@gaborgsomogyi

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Kafka related Spark parameters has to start with spark.kafka. and not with spark.sql.. Because of this I've renamed spark.sql.kafkaConsumerCache.capacity.

Since Kafka consumer caching is not documented I've added this also.

How was this patch tested?

Existing + added unit test.

cd docs
SKIP_API=1 jekyll build

and manual webpage check.

@gaborgsomogyi

Copy link
Copy Markdown
Contributor Author

cc @srowen

@SparkQA

SparkQA commented May 13, 2019

Copy link
Copy Markdown

Test build #105348 has finished for PR 24590 at commit f43ee4e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HeartSaVioR HeartSaVioR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/structured-streaming-kafka-integration.md Outdated
Comment thread docs/structured-streaming-kafka-integration.md Outdated
Comment thread docs/structured-streaming-kafka-integration.md Outdated
Comment thread docs/structured-streaming-kafka-integration.md Outdated
Comment thread docs/structured-streaming-kafka-integration.md Outdated
@SparkQA

SparkQA commented May 14, 2019

Copy link
Copy Markdown

Test build #105375 has finished for PR 24590 at commit 38bc96d.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gaborgsomogyi

Copy link
Copy Markdown
Contributor Author

retest this please

@SparkQA

SparkQA commented May 14, 2019

Copy link
Copy Markdown

Test build #105377 has finished for PR 24590 at commit 38bc96d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @gaborgsomogyi and @srowen , @HeartSaVioR .
Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27687][SS] Rename Kafka consumer cache capacity and document caching [SPARK-27687][SS] Rename Kafka consumer cache capacity conf and document caching May 15, 2019
@BdLearnerr

Copy link
Copy Markdown

@gaborgsomogyi

Copy link
Copy Markdown
Contributor Author

@BdLearnerr I've answered but next time please use the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants