Skip to content

[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals#25018

Closed
wangyum wants to merge 8 commits into
apache:masterfrom
wangyum:SPARK-26321
Closed

[SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals#25018
wangyum wants to merge 8 commits into
apache:masterfrom
wangyum:SPARK-26321

Conversation

@wangyum

@wangyum wangyum commented Jun 30, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This pr port HIVE-15297 to fix spark-sql should not split semicolon within quoted string literals.

How was this patch tested?

unit tests and manual tests:
image

@SparkQA

SparkQA commented Jun 30, 2019

Copy link
Copy Markdown

Test build #107050 has finished for PR 25018 at commit 279636d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-26321][SQL] Port HIVE-15297: spark-sql should not split semicolon within quoted string literals [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals Jul 1, 2019
@gatorsmile

Copy link
Copy Markdown
Member

Could you port the test cases from the original PR #23276

@SparkQA

SparkQA commented Jul 20, 2019

Copy link
Copy Markdown

Test build #107932 has finished for PR 25018 at commit 3e7318d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SparkSQLCLIDriverSuite extends SparkFunSuite
  • class SQLMatcher extends ArgumentMatcher[String]

@HyukjinKwon

Copy link
Copy Markdown
Member

@wangyum, if this is simply porting the fix, let's go ahead. can you resolve conflicts?

# Conflicts:
#	sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
#	sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
@wangyum

wangyum commented Sep 18, 2019

Copy link
Copy Markdown
Member Author

@HyukjinKwon Done

@SparkQA

SparkQA commented Sep 18, 2019

Copy link
Copy Markdown

Test build #110920 has finished for PR 25018 at commit 314a43e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

Copy link
Copy Markdown
Member

retest this please

@HyukjinKwon HyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyum, I think you can merge if you're pretty confident on this.

@wangyum

wangyum commented Oct 10, 2019

Copy link
Copy Markdown
Member Author

Thank you @HyukjinKwon I added another test case.

@SparkQA

SparkQA commented Oct 11, 2019

Copy link
Copy Markdown

Test build #111931 has finished for PR 25018 at commit f941a43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals [SPARK-26321][SQL][test-hadoop3.2] Port HIVE-15297: Hive should not split semicolon within quoted string literals Oct 12, 2019
@wangyum

wangyum commented Oct 12, 2019

Copy link
Copy Markdown
Member Author

retest this please

@SparkQA

SparkQA commented Oct 12, 2019

Copy link
Copy Markdown

Test build #111940 has finished for PR 25018 at commit f941a43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-26321][SQL][test-hadoop3.2] Port HIVE-15297: Hive should not split semicolon within quoted string literals [SPARK-26321][SQL] Port HIVE-15297: Hive should not split semicolon within quoted string literals Oct 13, 2019
@SparkQA

SparkQA commented Oct 13, 2019

Copy link
Copy Markdown

Test build #111990 has finished for PR 25018 at commit 48364a7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum closed this in 148cd26 Oct 13, 2019
@wangyum

wangyum commented Oct 13, 2019

Copy link
Copy Markdown
Member Author

Merged to master.

@wangyum wangyum deleted the SPARK-26321 branch October 13, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants