Skip to content

[SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test#25278

Closed
huaxingao wants to merge 1 commit into
apache:masterfrom
huaxingao:spark-28277n
Closed

[SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test#25278
huaxingao wants to merge 1 commit into
apache:masterfrom
huaxingao:spark-28277n

Conversation

@huaxingao

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fix for SPARK-28441 (PythonUDF used in correlated scalar subquery causes UnsupportedOperationException) is in. Re-enable the commented out test for udf(max(udf(column)))

How was this patch tested?

use existing test udf-except.sql

@SparkQA

SparkQA commented Jul 28, 2019

Copy link
Copy Markdown

Test build #108267 has finished for PR 25278 at commit d4562e9.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya

viirya commented Jul 28, 2019

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented Jul 28, 2019

Copy link
Copy Markdown

Test build #108276 has finished for PR 25278 at commit d4562e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @huaxingao and @viirya .
Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test [SPARK-28441][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test Jul 28, 2019
@dongjoon-hyun

dongjoon-hyun commented Jul 28, 2019

Copy link
Copy Markdown
Member

I understand the intention, @huaxingao . But, SPARK-28441 should have enabled this test in the PR together. I changed this to as a follow-up of SPARK-28441.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Oh, I missed @HyukjinKwon 's comment.
Okay, I change the PR title back.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28441][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test [SPARK-28277][SQL][PYTHON][TESTS][FOLLOW-UP] Re-enable commented out test Jul 28, 2019
@huaxingao

Copy link
Copy Markdown
Contributor Author

Thanks! @dongjoon-hyun @viirya

@HyukjinKwon

Copy link
Copy Markdown
Member

Ah, for trackabiliy, maybe 28441 was a better choice but should be fine either way.

@viirya

viirya commented Jul 29, 2019

Copy link
Copy Markdown
Member

Either is fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants