[SPARK-29187][SQL] Return null from date_part() for the null field#25865
Closed
MaxGekk wants to merge 3 commits into
Closed
[SPARK-29187][SQL] Return null from date_part() for the null field#25865MaxGekk wants to merge 3 commits into
date_part() for the null field#25865MaxGekk wants to merge 3 commits into
Conversation
adrian-wang
reviewed
Sep 20, 2019
| }) | ||
| val fieldEval = field.eval() | ||
| if (fieldEval == null) { | ||
| Literal(null, DoubleType) |
Member
Author
There was a problem hiding this comment.
See the example in the description. PostgreSQL returns NULL of the double precision type which is equivalent of DOUBLE type in Spark SQL. Which type would you use here?
|
Test build #111056 has finished for PR 25865 at commit
|
|
Test build #111058 has finished for PR 25865 at commit
|
dongjoon-hyun
approved these changes
Sep 21, 2019
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk .
Merged to master.
Member
|
Also, thank you for review, @adrian-wang . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to change behavior of the
date_part()function in handlingnullfield, and make it the same as PostgreSQL has. Iffieldparameter isnull, the function should returnnullof thedoubletype as PostgreSQL does:Why are the changes needed?
The
date_part()function was added to maintain feature parity with PostgreSQL but current behavior of the function is different in handling null asfield.Does this PR introduce any user-facing change?
Yes.
Before:
After:
How was this patch tested?
Add new tests to `DateFunctionsSuite for 2 cases:
field=null,source= a date literalfield=null,source= a date column