Skip to content

[SPARK-28772][BUILD][MLLIB] Update breeze to 1.0#25874

Closed
srowen wants to merge 2 commits into
apache:masterfrom
srowen:SPARK-28772
Closed

[SPARK-28772][BUILD][MLLIB] Update breeze to 1.0#25874
srowen wants to merge 2 commits into
apache:masterfrom
srowen:SPARK-28772

Conversation

@srowen

@srowen srowen commented Sep 20, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Update breeze dependency to 1.0.

Why are the changes needed?

Breeze 1.0 supports Scala 2.13 and has a few bug fixes.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@srowen srowen self-assigned this Sep 20, 2019
@SparkQA

SparkQA commented Sep 20, 2019

Copy link
Copy Markdown

Test build #111095 has finished for PR 25874 at commit be03b1f.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28772][MLLIB] Update breeze to 1.0 [SPARK-28772][BUILD][MLLIB] Update breeze to 1.0 Sep 21, 2019

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending Jenkins)
I also checked that the dependency is the same in JDK11.

@SparkQA

SparkQA commented Sep 21, 2019

Copy link
Copy Markdown

Test build #111100 has finished for PR 25874 at commit 1851e0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Merged to master. Thank you, @srowen .

@srowen srowen deleted the SPARK-28772 branch September 27, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants