[SPARK-27463][PYTHON][FOLLOW-UP] Miscellaneous documentation and code cleanup of cogroup pandas UDF#25939
Closed
d80tb7 wants to merge 9 commits into
Closed
[SPARK-27463][PYTHON][FOLLOW-UP] Miscellaneous documentation and code cleanup of cogroup pandas UDF#25939d80tb7 wants to merge 9 commits into
d80tb7 wants to merge 9 commits into
Conversation
HyukjinKwon
reviewed
Sep 26, 2019
Member
|
add to whitelist |
HyukjinKwon
reviewed
Sep 26, 2019
HyukjinKwon
reviewed
Sep 26, 2019
HyukjinKwon
changed the title
|
Test build #111410 has finished for PR 25939 at commit
|
|
Test build #111415 has finished for PR 25939 at commit
|
|
Test build #111430 has finished for PR 25939 at commit
|
|
Test build #111450 has finished for PR 25939 at commit
|
HyukjinKwon
approved these changes
Sep 27, 2019
HyukjinKwon
left a comment
HyukjinKwon
left a comment
Member
There was a problem hiding this comment.
LGTM otherwise. Thanks for addressing my comments @d80tb7.
|
Test build #111452 has finished for PR 25939 at commit
|
|
Test build #111574 has finished for PR 25939 at commit
|
Member
|
retest this please |
|
Test build #111579 has finished for PR 25939 at commit
|
Member
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 31, 2019
This PR adds some extra documentation for the new Cogrouped map Pandas udfs. Specifically: - Updated the usage guide for the new `COGROUPED_MAP` Pandas udfs added in #24981 - Updated the docstring for pandas_udf to include the COGROUPED_MAP type as suggested by HyukjinKwon in #25939 Closes #26110 from d80tb7/SPARK-29126-cogroup-udf-usage-guide. Authored-by: Chris Martin <chris@cmartinit.co.uk> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #24981 incorporating some comments from @HyukjinKwon.
Specifically:
CoGroupedDatatopyspark/sql/__init__.py __all__so that documentation is generated.This was tested by running the appropriate unit tests. I'm unsure as to how to check that my change will cause the documentation to be generated correctly, but it someone can describe how I can do this I'd be happy to check.