[SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership#26068
[SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership#26068yaooqinn wants to merge 5 commits into
Conversation
…a table's ownership
|
cc @wangyum |
|
retest this please |
|
Test build #111952 has finished for PR 26068 at commit
|
|
Test build #111964 has finished for PR 26068 at commit
|
| // If users explicitly alter these Hive-specific properties through ALTER TABLE DDL, we respect | ||
| // these user-specified values. | ||
| verifyColumnDataType(table.dataSchema) | ||
| val owner = Option(table.owner).filter(_.nonEmpty).getOrElse(userName) |
There was a problem hiding this comment.
Could we move this change to HiveClientImpl.scala#L1043?
Option(table.owner).filter(_.nonEmpty).orElse(userName).foreach(hiveTable.setOwner)There was a problem hiding this comment.
It sounds like a bigger deal than it is. Indeed, I am going to add alter table owner syntax, which may make this kind of change back and forth
There was a problem hiding this comment.
Hm, yea I think @wangyum's suggestion is more correct.
|
also cc @cloud-fan |
|
how is INSERT TABLE fixed in this PR? |
|
would eventually call alterTable here
|
|
can we add a test in |
|
Test build #112206 has finished for PR 26068 at commit
|
|
To clarify, this PR fixed the case of |
|
Test build #112215 has finished for PR 26068 at commit
|
|
Test build #112214 has finished for PR 26068 at commit
|
|
thanks, merging to master! |
6 participants
What changes were proposed in this pull request?
In this change, we give preference to the original table's owner if it is not empty.
Why are the changes needed?
When executing 'insert into/overwrite ...' DML, or 'alter table set tblproperties ...' DDL, spark would change the ownership of the table the one who runs the spark application.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Compare with the behavior of Apache Hive