Skip to content

[SPARK-29107][SQL][TESTS][FollowUp] Move window_part1.sql to directory 'postgreSQL'#26116

Closed
gengliangwang wants to merge 1 commit into
apache:masterfrom
gengliangwang:moveFile
Closed

[SPARK-29107][SQL][TESTS][FollowUp] Move window_part1.sql to directory 'postgreSQL'#26116
gengliangwang wants to merge 1 commit into
apache:masterfrom
gengliangwang:moveFile

Conversation

@gengliangwang

@gengliangwang gengliangwang commented Oct 14, 2019

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

rename sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql ->
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/window_part1.sql

rename sql/core/src/test/resources/sql-tests/results/pgSQL/window_part1.sql.out ->
sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part1.sql.out

Why are the changes needed?

After #25936 , the package pgSQL is renamed as postgreSQL

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test

@gengliangwang

Copy link
Copy Markdown
Member Author

I got this error after renaming the file

+org.apache.spark.sql.catalyst.parser.ParseException
+
+no viable alternative at input 'year'(line 3, pos 59)
+
+== SQL ==
+SELECT empno, depname, salary, bonus, depadj, MIN(bonus) OVER (ORDER BY empno), MAX(depadj) OVER () FROM(
+SELECT *,
+  CASE WHEN enroll_date < '2008-01-01' THEN 2008 - extract(year FROM enroll_date) END * 500 AS bonus,
+-----------------------------------------------------------^^^
+  CASE WHEN
+    AVG(salary) OVER (PARTITION BY depname) < salary
+    THEN 200 END AS depadj FROM empsalary
+  )s

Also, it fails the ANSI table insertion policy:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112055/consoleFull

I am thinking about reverting the PR #25816. After #26107 is merged, we can manage to add the window_part1.sql back correctly.

@SparkQA

SparkQA commented Oct 14, 2019

Copy link
Copy Markdown

Test build #112070 has finished for PR 26116 at commit f8b68a4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Since the Jenkins fails, the reverting is better. I reverted it. Thanks, @gengliangwang .

@gengliangwang

Copy link
Copy Markdown
Member Author

@dongjoon-hyun Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants