[SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands#26129
Closed
cloud-fan wants to merge 3 commits into
Closed
[SPARK-29482][SQL] ANALYZE TABLE should look up catalog/table like v2 commands#26129cloud-fan wants to merge 3 commits into
cloud-fan wants to merge 3 commits into
Conversation
Contributor
Author
|
Test build #112118 has finished for PR 26129 at commit
|
imback82
reviewed
Oct 15, 2019
| * Create an [[AnalyzeTableStatement]], or an [[AnalyzeColumnStatement]]. | ||
| * Example SQL for analyzing a table or a set of partitions : | ||
| * {{{ | ||
| * ANALYZE TABLE [db_name.]tablename [PARTITION (partcol1[=val1], partcol2[=val2], ...)] |
Contributor
There was a problem hiding this comment.
nit: db_name. needs to be updated now that multipartIdentifier is parsed? (although the scenario is not currently supported)
imback82
approved these changes
Oct 15, 2019
imback82
left a comment
imback82
left a comment
Contributor
There was a problem hiding this comment.
LGTM (one minor comment)
|
Test build #112136 has finished for PR 26129 at commit
|
Contributor
Author
|
retest this please |
|
Test build #112164 has finished for PR 26129 at commit
|
| case class UseStatement(isNamespaceSet: Boolean, nameParts: Seq[String]) extends ParsedStatement | ||
|
|
||
| /** | ||
| * A ANALYZE TABLE statement, as parsed from SQL. |
| noScan: Boolean) extends ParsedStatement | ||
|
|
||
| /** | ||
| * A ANALYZE TABLE FOR COLUMNS statement, as parsed from SQL. |
gengliangwang
approved these changes
Oct 17, 2019
gengliangwang
left a comment
gengliangwang
left a comment
Member
There was a problem hiding this comment.
LGTM except minor comments
viirya
approved these changes
Oct 17, 2019
|
Test build #112255 has finished for PR 26129 at commit
|
Member
|
retest this please. |
|
Test build #112259 has finished for PR 26129 at commit
|
Member
|
Thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
AnalyzeTableStatementandAnalyzeColumnStatement, and make ANALYZE TABLE go through the same catalog/table resolution framework of v2 commands.Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.
Does this PR introduce any user-facing change?
yes. When running ANALYZE TABLE, Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.
How was this patch tested?
new tests