[SPARK-29512][SQL] REPAIR TABLE should look up catalog/table like v2 commands#26168
Closed
imback82 wants to merge 1 commit into
Closed
[SPARK-29512][SQL] REPAIR TABLE should look up catalog/table like v2 commands#26168imback82 wants to merge 1 commit into
imback82 wants to merge 1 commit into
Conversation
Contributor
Author
|
cc: @cloud-fan @rdblue @viirya |
viirya
approved these changes
Oct 18, 2019
rdblue
approved these changes
Oct 18, 2019
|
Test build #112294 has finished for PR 26168 at commit
|
Member
|
Thanks! Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add RepairTableStatement and make REPAIR TABLE go through the same catalog/table resolution framework of v2 commands.
Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.
Does this PR introduce any user-facing change?
yes. When running MSCK REPAIR TABLE, Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.
How was this patch tested?
New unit tests