[SPARK-29531][SQL][TEST]refine ThriftServerQueryTestSuite.blackList to reuse black list in SQLQueryTestSuite#26188
Closed
fuwhu wants to merge 2 commits into
Closed
[SPARK-29531][SQL][TEST]refine ThriftServerQueryTestSuite.blackList to reuse black list in SQLQueryTestSuite#26188fuwhu wants to merge 2 commits into
fuwhu wants to merge 2 commits into
Conversation
Member
|
ok to test |
…QLQueryTestSuite
by calling super.blackList instead of duplicating all test cases from SQLQueryTestSuite.blackList
|
Test build #112375 has finished for PR 26188 at commit
|
|
Test build #112380 has finished for PR 26188 at commit
|
wangyum
approved these changes
Oct 21, 2019
Member
|
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr refine the code in ThriftServerQueryTestSuite.blackList to reuse the black list of SQLQueryTestSuite instead of duplicating all test cases from SQLQueryTestSuite.blackList.
Why are the changes needed?
To reduce code duplication.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A