[SPARK-29528][BUILD] Upgrade scala-maven-plugin to 4.3.0 for Scala 2.13.1#26457
Closed
dongjoon-hyun wants to merge 3 commits into
Closed
[SPARK-29528][BUILD] Upgrade scala-maven-plugin to 4.3.0 for Scala 2.13.1#26457dongjoon-hyun wants to merge 3 commits into
dongjoon-hyun wants to merge 3 commits into
Conversation
This was referenced Nov 10, 2019
dongjoon-hyun
commented
Nov 10, 2019
| @@ -1,4 +1,4 @@ | |||
| # R on Spark | |||
| # R on Spark! | |||
Member
Author
There was a problem hiding this comment.
This is only for triggering AppVoyer and this will be reverted before merging.
Member
|
Thanks @dongjoon-hyun for trying this out! |
Member
Author
|
Thank you. AppVeyor passed! |
|
Test build #113525 has finished for PR 26457 at commit
|
|
Test build #113526 has finished for PR 26457 at commit
|
This reverts commit 4020832.
|
Test build #113534 has finished for PR 26457 at commit
|
dongjoon-hyun
commented
Nov 10, 2019
dongjoon-hyun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
scala-maven-pluginto4.3.0for Scala2.13.1.We tried 4.2.4, but it's reverted due to Windows build issue. Now,
4.3.0has a Window fix.Why are the changes needed?
Scala 2.13.1 seems to break the binary compatibility.
We need to upgrade
scala-maven-pluginto bring the the following fixes for the latest Scala 2.13.1.Also,
4.3.0has the following Window fix.Does this PR introduce any user-facing change?
No.
How was this patch tested?
AppVeyorpassed. (https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/28745383)