Skip to content

[SPARK-30231][SQL][PYTHON][FOLLOWUP] Make error messages clear in PySpark df.explain #26886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maropu wants to merge 2 commits into from
Closed

[SPARK-30231][SQL][PYTHON][FOLLOWUP] Make error messages clear in PySpark df.explain #26886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e581fd
Fix
maropu Dec 13, 2019
d98e261
Fix
maropu Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions python/pyspark/sql/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,12 @@ def explain(self, extended=None, mode=None):
is_mode_case = mode is not None and isinstance(mode, basestring)

if not is_no_argument and not (is_extended_case or is_mode_case):
argtypes = [
str(type(arg)) for arg in [extended, mode] if arg is not None]
raise TypeError(
"extended (optional) and mode (optional) should be a bool and str; "
"however, got [%s]." % ", ".join(argtypes))
if extended is not None:
errMsg = "extended (optional) should be provided as bool" \
", got {0}".format(type(extended))
else: # For mode case
errMsg = "mode (optional) should be provided as str, got {0}".format(type(mode))
raise TypeError(errMsg)
Comment thread
dongjoon-hyun marked this conversation as resolved.

# Sets an explain mode depending on a given argument
if is_no_argument:
Expand Down
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,6 +547,7 @@ class Dataset[T] private[sql](
}
}

// This method intends to be called from PySpark DataFrame
Comment thread
dongjoon-hyun marked this conversation as resolved.
private[sql] def toExplainString(mode: String): String = {
mode.toLowerCase(Locale.ROOT) match {
case "simple" => toExplainString(ExplainMode.Simple)
Expand Down