Skip to content

[SPARK-30333][BUILD][FOLLOWUP][2.4] Update sbt build together#27256

Closed
dongjoon-hyun wants to merge 1 commit into
apache:branch-2.4from
dongjoon-hyun:SPARK-30333
Closed

[SPARK-30333][BUILD][FOLLOWUP][2.4] Update sbt build together#27256
dongjoon-hyun wants to merge 1 commit into
apache:branch-2.4from
dongjoon-hyun:SPARK-30333

Conversation

@dongjoon-hyun

@dongjoon-hyun dongjoon-hyun commented Jan 17, 2020

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR aims to update SparkBuild.scala as a follow-up of
SPARK-30333 Upgrade jackson-databind to 2.6.7.3.

Why are the changes needed?

Since SPARK-29781, we override SBT Jackson dependency like Maven.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30333][CORE][BUILD][FOLLOWUP][2.4] Update sbt build together [SPARK-30333][BUILD][FOLLOWUP][2.4] Update sbt build together Jan 17, 2020
@SparkQA

SparkQA commented Jan 17, 2020

Copy link
Copy Markdown

Test build #116918 has finished for PR 27256 at commit 3324def.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Hi, @viirya . CRAN incoming feasibility test seems to fail again.

  • checking CRAN incoming feasibility ...Error in readRDS(con) : error reading from connection
    Execution halted

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

All the other tests (except the flaky CRAN incoming check) passed. I'll merge this to branch-2.4.

dongjoon-hyun added a commit that referenced this pull request Jan 17, 2020
### What changes were proposed in this pull request?

This PR aims to update `SparkBuild.scala` as a follow-up of
[SPARK-30333 Upgrade jackson-databind to 2.6.7.3](#26986).

### Why are the changes needed?

Since SPARK-29781, we override SBT Jackson dependency like Maven.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the Jenkins.

Closes #27256 from dongjoon-hyun/SPARK-30333.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-30333 branch January 17, 2020 16:04
@viirya

viirya commented Jan 17, 2020

Copy link
Copy Markdown
Member

This error looks a bit different to previous ones. Looks like a connection error? Is it repeatedly occurred?

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

I hope it's not. Otherwise, it will be a blocker for 2.4.5 release because we cannot upload the artifacts to CRAN. Let's monitor the Jenkins result.

@viirya

viirya commented Jan 17, 2020

Copy link
Copy Markdown
Member

@dongjoon-hyun Ok. Please inform me if you see it repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants