Skip to content

[SPARK-29924][DOCS] Document Apache Arrow JDK11 requirement#27356

Closed
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-JDK11-ARROW-DOC
Closed

[SPARK-29924][DOCS] Document Apache Arrow JDK11 requirement#27356
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-JDK11-ARROW-DOC

Conversation

@dongjoon-hyun

@dongjoon-hyun dongjoon-hyun commented Jan 24, 2020

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This adds a note for additional setting for Apache Arrow library for Java 11.

Why are the changes needed?

Since Apache Arrow 0.14.0, an additional setting is required for Java 9+.

It's explicitly documented at Apache Arrow 0.15.0.

However, there is no plan to handle that inside Apache Arrow side.

In short, we need to document this for the users who is using Arrow-related feature on JDK11.

For dev environment, we handle this via SPARK-29923 .

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

Generated document and see the pages.

doc

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29924][DOCS] Add Apache Arrow requirement in Java 11 [SPARK-29924][DOCS] Add Apache Arrow requirement on Java 11 Jan 24, 2020
@dongjoon-hyun

Copy link
Copy Markdown
Member Author

cc @HyukjinKwon , @BryanCutler , @srowen .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-29924][DOCS] Add Apache Arrow requirement on Java 11 [SPARK-29924][DOCS] Document Apache Arrow JDK11 requirement Jan 24, 2020
@SparkQA

SparkQA commented Jan 24, 2020

Copy link
Copy Markdown

Test build #117369 has finished for PR 27356 at commit ed7f624.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Thank you, @srowen . Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-JDK11-ARROW-DOC branch January 24, 2020 19:54

@BryanCutler BryanCutler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dongjoon-hyun !

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Thank you, @BryanCutler !

@HyukjinKwon HyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjoon-hyun

Copy link
Copy Markdown
Member Author

Thanks, @HyukjinKwon . It's a holiday in South Korea, isn't it? 😉

@chogg

chogg commented Jan 15, 2021

Copy link
Copy Markdown

Will the io.netty.tryReflectionSetAccessible=true be set automatically at any point in the future, or will users always need to set this manually? Is there a downside to always setting this to true?

Thanks for your help here :)

@dongjoon-hyun

dongjoon-hyun commented Jan 16, 2021

Copy link
Copy Markdown
Member Author

@chogg . Unfortunately, Apache Spark cannot add it by default with the same reason why Netty and Apache Arrow project didn't add it automatically.

Could you ask that to the Netty or Apache Arrow community instead?

@romainx

romainx commented Mar 21, 2021

Copy link
Copy Markdown

Hello.

For information we observed that this setting seems to not be required anymore with new versions of the libraries. See jupyter/docker-stacks#1256 for detail.

Best.

@HyukjinKwon

Copy link
Copy Markdown
Member

Thanks for heads up @romainx. Would you be interested in fixing it? See also http://spark.apache.org/contributing.html

@romainx

romainx commented Mar 22, 2021

Copy link
Copy Markdown

@HyukjinKwon sure I will have a look and I will try to draft a PR, it could take some time since it's my first contribution here. Thanks for the proposal.

@HyukjinKwon

Copy link
Copy Markdown
Member

Sure, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants