[SPARK-31553][SQL][TESTS][FOLLOWUP] Tests for collection elem types of isInCollection #28405
Closed
MaxGekk wants to merge 2 commits into
Closed
[SPARK-31553][SQL][TESTS][FOLLOWUP] Tests for collection elem types of isInCollection #28405MaxGekk wants to merge 2 commits into
isInCollection #28405MaxGekk wants to merge 2 commits into
Conversation
|
Test build #122061 has finished for PR 28405 at commit
|
Member
Author
|
@cloud-fan @HyukjinKwon @dongjoon-hyun Please, review this PR. |
HyukjinKwon
approved these changes
Apr 30, 2020
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 30, 2020
…f `isInCollection` ### What changes were proposed in this pull request? - Add tests for different element types of collections that could be passed to `isInCollection`. Added tests for types that can pass the check `In`.`checkInputDataTypes()`. - Test different switch thresholds in the `isInCollection: Scala Collection` test. ### Why are the changes needed? To prevent regressions like introduced by #25754 and reverted by #28388 ### Does this PR introduce any user-facing change? No ### How was this patch tested? By existing and new tests in `ColumnExpressionSuite` Closes #28405 from MaxGekk/test-isInCollection. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 9164865) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
isInCollection. Added tests for types that can pass the checkIn.checkInputDataTypes().isInCollection: Scala Collectiontest.Why are the changes needed?
To prevent regressions like introduced by #25754 and reverted by #28388
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing and new tests in
ColumnExpressionSuite