[SPARK-32018][SQL][2.4] UnsafeRow.setDecimal should set null with overflowed value#29141
Closed
cloud-fan wants to merge 1 commit into
Closed
[SPARK-32018][SQL][2.4] UnsafeRow.setDecimal should set null with overflowed value#29141cloud-fan wants to merge 1 commit into
cloud-fan wants to merge 1 commit into
Conversation
…rflowed value partially backport apache#29026 Closes apache#29125 from cloud-fan/backport. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Contributor
Author
Member
|
Thank you, @cloud-fan ! |
|
Test build #126030 has finished for PR 29141 at commit
|
Member
|
Retest this please. |
|
Test build #126037 has finished for PR 29141 at commit
|
dongjoon-hyun
approved these changes
Jul 17, 2020
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
Member
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.4.
Contributor
Author
|
I'm reverting it from 2.4, see #29450 (comment) |
Member
|
Got it. I understand the situation. Thank you for the decision, @cloud-fan . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #29125