Skip to content

[SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc#29315

Closed
xuanyuanking wants to merge 3 commits into
apache:masterfrom
xuanyuanking:SPARK-31894-follow
Closed

[SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc#29315
xuanyuanking wants to merge 3 commits into
apache:masterfrom
xuanyuanking:SPARK-31894-follow

Conversation

@xuanyuanking

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Address comment in #28707 (comment)

Why are the changes needed?

Hide the implementation details in the config doc.

Does this PR introduce any user-facing change?

Config doc change.

How was this patch tested?

Document only.

@xuanyuanking xuanyuanking changed the title [SPARK-31894][SS][FOLLOW-UP] [SPARK-31894][SS][FOLLOW-UP] Rephrase the config doc Jul 31, 2020
@xuanyuanking

Copy link
Copy Markdown
Member Author

cc @cloud-fan

Comment thread sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala Outdated
@cloud-fan

Copy link
Copy Markdown
Contributor

do we have the same problem in the error message?

@cloud-fan

Copy link
Copy Markdown
Contributor

cc @HeartSaVioR

@xuanyuanking

Copy link
Copy Markdown
Member Author

https://github.com/apache/spark/pull/28707/files#diff-238c6b2f820f62c556f204788d684584R150
I think the error message is clear, we don't use code name inside.

Comment thread sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala Outdated
@SparkQA

SparkQA commented Jul 31, 2020

Copy link
Copy Markdown

Test build #126880 has finished for PR 29315 at commit a358345.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan

Copy link
Copy Markdown
Contributor

This just updates the config doc and we don't need to wait for the test. Thanks, merging to master!

@cloud-fan cloud-fan closed this in 354313b Jul 31, 2020
@SparkQA

SparkQA commented Jul 31, 2020

Copy link
Copy Markdown

Test build #126883 has finished for PR 29315 at commit 376989d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@xuanyuanking xuanyuanking deleted the SPARK-31894-follow branch August 1, 2020 00:20
@HeartSaVioR

Copy link
Copy Markdown
Contributor

post +1. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants