Skip to content

[SPARK-32971][K8S][FOLLOWUP] Fix k8s-core module compilation in Scala 2.13#29861

Closed
LuciferYang wants to merge 1 commit into
apache:masterfrom
LuciferYang:SPARK-32971-FOLLOWUP
Closed

[SPARK-32971][K8S][FOLLOWUP] Fix k8s-core module compilation in Scala 2.13#29861
LuciferYang wants to merge 1 commit into
apache:masterfrom
LuciferYang:SPARK-32971-FOLLOWUP

Conversation

@LuciferYang

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Manual call toSeq of MountVolumesFeatureStep.getAdditionalKubernetesResources method because ArrayBuffer not a Seq in Scala 2.13

Why are the changes needed?

We need to support a Scala 2.13 build.

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Scala 2.12: Pass the Jenkins or GitHub Action

  • Scala 2.13: Pass GitHub 2.13 Build Action

@LuciferYang

Copy link
Copy Markdown
Contributor Author

cc @dongjoon-hyun The change of SPARK-32971 blocking GitHub 2.13 build Action

@LuciferYang LuciferYang changed the title [SPARK-32971][K8S][FOLLOWUP] Fix k8s core module compile in Scala 2.13 [SPARK-32971][K8S][FOLLOWUP] Fix k8s core module compilation in Scala 2.13 Sep 24, 2020
@LuciferYang LuciferYang changed the title [SPARK-32971][K8S][FOLLOWUP] Fix k8s core module compilation in Scala 2.13 [SPARK-32971][K8S][FOLLOWUP] Fix k8s-core module compilation in Scala 2.13 Sep 24, 2020
@LuciferYang

Copy link
Copy Markdown
Contributor Author

also ping @HyukjinKwon

@dongjoon-hyun

Copy link
Copy Markdown
Member

master branch is already green, isn't it?
Screen Shot 2020-09-23 at 9 53 35 PM


override def getAdditionalKubernetesResources(): Seq[HasMetadata] = {
additionalResources
additionalResources.toSeq

@dongjoon-hyun dongjoon-hyun Sep 24, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SparkQA

SparkQA commented Sep 24, 2020

Copy link
Copy Markdown

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33682/

@dongjoon-hyun

Copy link
Copy Markdown
Member

Please reopen this if the master branch is broken really.

@LuciferYang

Copy link
Copy Markdown
Contributor Author

@dongjoon-hyun ok, I found #29859 fix this today :)

@dongjoon-hyun

Copy link
Copy Markdown
Member

:)

@SparkQA

SparkQA commented Sep 24, 2020

Copy link
Copy Markdown

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33682/

@SparkQA

SparkQA commented Sep 24, 2020

Copy link
Copy Markdown

Test build #129061 has finished for PR 29861 at commit 6ef5c2b.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LuciferYang LuciferYang deleted the SPARK-32971-FOLLOWUP branch June 6, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants