[SPARK-34774][BUILD] Ensure change-scala-version.sh update scala.version in parent POM correctly

[LuciferYang]

What changes were proposed in this pull request?

After SPARK-34507, execute change-scala-version.sh script will update scala.version in parent pom, but if we execute the following commands in order：

dev/change-scala-version.sh 2.13
dev/change-scala-version.sh 2.12
git status

there will generate git diff as follow:

diff --git a/pom.xml b/pom.xml
index ddc4ce2f68..f43d8c8f78 100644
--- a/pom.xml
+++ b/pom.xml
@@ -162,7 +162,7 @@
     <commons.math3.version>3.4.1</commons.math3.version>
     <!-- managed up from 3.2.1 for SPARK-11652 -->
     <commons.collections.version>3.2.2</commons.collections.version>
-    <scala.version>2.12.10</scala.version>
+    <scala.version>2.13.5</scala.version>
     <scala.binary.version>2.12</scala.binary.version>
     <scalatest-maven-plugin.version>2.0.0</scalatest-maven-plugin.version>
     <scalafmt.parameters>--test</scalafmt.parameters>

seem 'scala.version' property was not update correctly.

So this pr add an extra 'scala.version' to scala-2.12 profile to ensure change-scala-version.sh can update the public scala.version property correctly.

Why are the changes needed?

Bug fix.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manual test

Execute the following commands in order：

dev/change-scala-version.sh 2.13
dev/change-scala-version.sh 2.12
git status

Before

diff --git a/pom.xml b/pom.xml
index ddc4ce2f68..f43d8c8f78 100644
--- a/pom.xml
+++ b/pom.xml
@@ -162,7 +162,7 @@
     <commons.math3.version>3.4.1</commons.math3.version>
     <!-- managed up from 3.2.1 for SPARK-11652 -->
     <commons.collections.version>3.2.2</commons.collections.version>
-    <scala.version>2.12.10</scala.version>
+    <scala.version>2.13.5</scala.version>
     <scala.binary.version>2.12</scala.binary.version>
     <scalatest-maven-plugin.version>2.0.0</scalatest-maven-plugin.version>
     <scalafmt.parameters>--test</scalafmt.parameters>

After

No git diff.

[LuciferYang]

cc @srowen @HyukjinKwon

[AmplabJenkins]

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136154/

[AmplabJenkins]

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40735/

[sarutak]

Hmm, this seems to duplicate #31863.

[LuciferYang]

Hmm, this seems to duplicate #31863.

@sarutak It seems that we found the same problem almost at the same time :)

But maybe add a scala.version property to the scala-2.12 profile will be able to keep the fix for SPARK-34507, the disadvantage is that this is a duplicate property in parent

[sarutak]

O.K, this solution can be more prominent.

[srowen]

I'm surprised if it can't be evaluated without being in a profile?

[LuciferYang]

I'm surprised if it can't be evaluated without being in a profile?

@srowen Yes, at least the above test method will trigger this problem, but I'm not sure if there's a better way to fix it

[srowen]

Fix seems fine is so FWIW

[HyukjinKwon]

I'm okay with this.

[AmplabJenkins]

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40778/

[AmplabJenkins]

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136196/

[srowen]

(Jenkins won't test this anyway, note)
Merged to master / 3.1 / 3.0.
@LuciferYang do you want to make a similar change for 2.x? I can do it too.

[LuciferYang]

@LuciferYang do you want to make a similar change for 2.x? I can do it too.

@srowen OK, I will do this later ~

[LuciferYang]

@LuciferYang do you want to make a similar change for 2.x? I can do it too.

@srowen for branch-2.4: #31893