Skip to content

[SPARK-34674][CORE][K8S] Close SparkContext after the Main method has finished #32081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kotlovs wants to merge 2 commits into from
Closed

[SPARK-34674][CORE][K8S] Close SparkContext after the Main method has finished #32081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdfbf08
Close SparkContext after the Main method has finished, to allow Spark…
kotlovs Apr 7, 2021
e3946b4
Close SparkContext after the Main method has finished, to allow Spark…
kotlovs Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,6 +952,12 @@ private[spark] class SparkSubmit extends Logging {
} catch {
case t: Throwable =>
throw findCause(t)
} finally {
try {
SparkContext.getActive.foreach(_.stop())

@HyukjinKwon HyukjinKwon Jul 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reading this and #33154, shouldn't we enable this only w/ Kubernates (and also when it's not a Thirftserver, shall, etc.)?

Also, I think we might have to add some comments on that.

@HyukjinKwon HyukjinKwon Jul 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sunpe too FYI

@Ngone51 Ngone51 Jul 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon This PR was reverted once and resubmitted #32283 (in which Thirftserver and others are excluded).

But I agree with you that we should only do this for K8s. Otherwise, it looks like a behavior change to me.

@dongjoon-hyun dongjoon-hyun Jul 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we continue the discussion on the latest one, #32282 , please?

@mridulm mridulm Jul 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun that pr looks unrelated, right ? Not sure if I am missing something.

@dongjoon-hyun dongjoon-hyun Jul 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It's a typo of #32283 . I tried to mention the one from @Ngone51 's comment.

@mridulm mridulm Jul 16, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dongjoon-hyun ! Was not sure if there was another pr also I should be looking at :-)

} catch {
case e: Throwable => logError(s"Failed to close SparkContext: $e")
}
}
}

Expand Down