[SPARK-35378][SQL][FOLLOWUP] Restore the command execution name for DataFrameWriterV2#32919
[SPARK-35378][SQL][FOLLOWUP] Restore the command execution name for DataFrameWriterV2#32919cloud-fan wants to merge 2 commits into
Conversation
|
cc @beliefer |
|
Test build #139817 has finished for PR 32919 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #139838 has finished for PR 32919 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
|
||
| assert(executedPlan.isInstanceOf[CommandResultExec]) | ||
| executedPlan.asInstanceOf[CommandResultExec].commandPhysicalPlan match { | ||
| executedPlan match { |
There was a problem hiding this comment.
So I reverted these changes from your previous commit.
|
Test build #139859 has finished for PR 32919 at commit
|
|
thanks for review, merging to master! |
What changes were proposed in this pull request?
This is a followup of #32513
It's hard to keep the command execution name for
DataFrameWriter, as the command logical plan is a bit messy (DS v1, file source and hive and different command logical plans) and sometimes it's hard to distinguish "insert" and "save".However,
DataFrameWriterV2only produce v2 commands which are pretty clean. It's easy to keep the command execution name for them.Why are the changes needed?
less breaking changes.
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A