Skip to content

[SPARK-37729][SQL] Fix SparkContext.setLogLevel that is not working in Spark Shell #35012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 1 commit into from
Closed

[SPARK-37729][SQL] Fix SparkContext.setLogLevel that is not working in Spark Shell #35012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions core/src/main/scala/org/apache/spark/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ import org.apache.hadoop.io.compress.{CompressionCodecFactory, SplittableCompres
import org.apache.hadoop.security.UserGroupInformation
import org.apache.hadoop.util.{RunJar, StringUtils}
import org.apache.hadoop.yarn.conf.YarnConfiguration
import org.apache.logging.log4j.{Level, LogManager}
import org.apache.logging.log4j.core.LoggerContext
import org.eclipse.jetty.util.MultiException
import org.slf4j.Logger

Expand Down Expand Up @@ -2423,11 +2425,13 @@ private[spark] object Utils extends Logging {
/**
* configure a new log4j level
*/
def setLogLevel(l: org.apache.logging.log4j.Level): Unit = {
val rootLogger = org.apache.logging.log4j.LogManager.getRootLogger()
.asInstanceOf[org.apache.logging.log4j.core.Logger]
rootLogger.setLevel(l)
rootLogger.get().setLevel(l)
def setLogLevel(l: Level): Unit = {
val ctx = LogManager.getContext(false).asInstanceOf[LoggerContext]
val config = ctx.getConfiguration()
val loggerConfig = config.getLoggerConfig(LogManager.ROOT_LOGGER_NAME)
loggerConfig.setLevel(l)
ctx.updateLoggers()

// Setting threshold to null as rootLevel will define log level for spark-shell
Logging.sparkShellThresholdLevel = null
}
Expand Down
3 changes: 3 additions & 0 deletions core/src/test/scala/org/apache/spark/util/UtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,8 +690,11 @@ class UtilsSuite extends SparkFunSuite with ResetSystemProperties with Logging {
try {
Utils.setLogLevel(org.apache.logging.log4j.Level.ALL)
assert(rootLogger.getLevel == org.apache.logging.log4j.Level.ALL)
assert(log.isInfoEnabled())
Utils.setLogLevel(org.apache.logging.log4j.Level.ERROR)
assert(rootLogger.getLevel == org.apache.logging.log4j.Level.ERROR)
assert(!log.isInfoEnabled())
assert(log.isErrorEnabled())
} finally {
// Best effort at undoing changes this test made.
Utils.setLogLevel(current)
Expand Down