[SPARK-40308][SQL] Allow non-foldable delimiter arguments to str_to_map function#37763
Closed
bersprockets wants to merge 3 commits into
Closed
[SPARK-40308][SQL] Allow non-foldable delimiter arguments to str_to_map function#37763bersprockets wants to merge 3 commits into
str_to_map function#37763bersprockets wants to merge 3 commits into
Conversation
bersprockets
commented
Sep 1, 2022
| Seq(Row(Map("a" -> "1", "b" -> "2", "c" -> "3"))) | ||
| ) | ||
|
|
||
| checkAnswer( |
Contributor
Author
There was a problem hiding this comment.
Not really a test of my change, but it was a missing test (the case where a literal pair delimiter is given but no key/value delimiter is given).
HyukjinKwon
approved these changes
Sep 2, 2022
Member
|
@cloud-fan I wonder why did you insist in #13990 (comment) that the delimiters must be foldable. |
MaxGekk
reviewed
Sep 3, 2022
| } else { | ||
| super.checkInputDataTypes() | ||
| } | ||
| super.checkInputDataTypes() |
Member
There was a problem hiding this comment.
If you invoke only the parent method, let's remove checkInputDataTypes() then.
MaxGekk
approved these changes
Sep 3, 2022
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the check for foldable delimiter arguments from
StringToMap#checkInputDataTypes.Except for
checkInputDataTypes,StringToMapis already able to handle non-foldable delimiter arguments (no other changes are required).Why are the changes needed?
Hive 2.3.9 allows non-foldable delimiter arguments, e.g.:
This returns
However, Spark returns an error:
The use-case is more likely to be something like this:
Does this PR introduce any user-facing change?
Yes, users can now specify non-foldable delimiter arguments to
str_to_map.Literals are still accepted, so the change is backwardly compatible.
How was this patch tested?
New unit tests.