Skip to content

[SPARK-37555][TEST][FOLLOWUP] Increase timeout of CLI test spark-sql should pass last unclosed comment to backend#38571

Closed
AngersZhuuuu wants to merge 6 commits into
apache:masterfrom
AngersZhuuuu:SPARK-37555-FOLOWUP
Closed

[SPARK-37555][TEST][FOLLOWUP] Increase timeout of CLI test spark-sql should pass last unclosed comment to backend#38571
AngersZhuuuu wants to merge 6 commits into
apache:masterfrom
AngersZhuuuu:SPARK-37555-FOLOWUP

Conversation

@AngersZhuuuu

@AngersZhuuuu AngersZhuuuu commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fix flaky test spark-sql should pass last unclosed comment to backend,
it's timeout should be caused by unstable GA env, so I increase timeout time for the test

Why are the changes needed?

Fix flaky test.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Not need

… should pass last unclosed comment to backend`
@LuciferYang

Copy link
Copy Markdown
Contributor

flaky test?

@AngersZhuuuu

Copy link
Copy Markdown
Contributor Author

flaky test?

yea

@AngersZhuuuu

Copy link
Copy Markdown
Contributor Author

@cloud-fan Triggered six times, the flaky test not failed.

@cloud-fan

Copy link
Copy Markdown
Contributor

@AngersZhuuuu can you fill the PR description? Then we can merge it.

@AngersZhuuuu

Copy link
Copy Markdown
Contributor Author

@AngersZhuuuu can you fill the PR description? Then we can merge it.

done

@cloud-fan

Copy link
Copy Markdown
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 058fe27 Nov 14, 2022
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
… should pass last unclosed comment to backend`

### What changes were proposed in this pull request?
Fix flaky test  `spark-sql should pass last unclosed comment to backend`,
it's timeout should be caused by unstable GA env, so I increase timeout time for the test

### Why are the changes needed?
Fix flaky test.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Not need

Closes apache#38571 from AngersZhuuuu/SPARK-37555-FOLOWUP.

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants