[SPARK-4943][SQL] Allow table name having dot for db/catalog

[alexliu68]

The pull only fixes the parsing error and changes API to use tableIdentifier. Joining different catalog datasource related change is not done in this pull.

[AmplabJenkins]

Can one of the admins verify this patch?

[marmbrus]

I think this should probably just be a single rule. With something like: repsep(ident, ",") for the table identifier.

[alexliu68]

I change it to rep1sep(ident, ".")

[marmbrus]

Thanks for doing this cleanup! Overall I think this looks pretty good. I made a few small comments. One other very minor nit. It seems a little odd to me to be using IndexedSeq everywhere instead of just Seq or :: Nil.

[marmbrus]

Also, can you fix the PR title to avoid truncating.

[marmbrus]

ok to test

[SparkQA]

Test build #25340 has started for PR 3941 at commit 29e5e55.

• This patch merges cleanly.

[alexliu68]

I use IndexedSeq instead Seq for IndexedSeq is faster to access element by lift. I can revert them back to Seq.

[marmbrus]

Its minor, but it seems unlikely that it it noticeably faster in this instance.

[SparkQA]

Test build #25340 has finished for PR 3941 at commit 29e5e55.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25340/
Test PASSed.

[SparkQA]

Test build #25356 has started for PR 3941 at commit 343ae27.

• This patch merges cleanly.

[SparkQA]

Test build #25356 has finished for PR 3941 at commit 343ae27.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25356/
Test PASSed.

[yhuai]

@alexliu68 Is there any particular reason that org.apache.spark.sql.hive.HiveMetastoreCatalog#createTable does not take a tableIdentifier: Seq[String]?

[alexliu68]

I only change selection to use tableIdentifier for joining tables. I keep createTable no change to minimize API changes. createTable could also use tableIdentifier to create catalog/cluster/database level table, but I leave it for future development if we need it.