-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-43009][SQL] Parameterized sql() with Any constants
#40623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5844cbb
9cdf053
7bc0bec
302f801
9ff50d0
5c0c455
b07ccf2
0a7da2b
5b7d90b
4543764
c482018
ae11139
ba54339
f6b9ee4
67f34e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -53,11 +53,8 @@ message SqlCommand { | |||||||||||||||||
| // (Required) SQL Query. | ||||||||||||||||||
| string sql = 1; | ||||||||||||||||||
|
|
||||||||||||||||||
| // (Optional) A map of parameter names to string values that are parsed as | ||||||||||||||||||
| // SQL literal expressions. For example, map keys: "rank", "name", "birthdate"; | ||||||||||||||||||
| // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string values | ||||||||||||||||||
| // belonged to SQL comments are skipped while parsing. | ||||||||||||||||||
| map<string, string> args = 2; | ||||||||||||||||||
| // (Optional) A map of parameter names to literal expressions. | ||||||||||||||||||
| map<string, Expression.Literal> args = 2; | ||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @grundprinzip are these protocol changes ok?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is an incomatible change.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would be valid:
Suggested change
so might be
Suggested change
Please run |
||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| // A command that can create DataFrame global temp view or local temp view. | ||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,11 +108,8 @@ message SQL { | |
| // (Required) The SQL query. | ||
| string query = 1; | ||
|
|
||
| // (Optional) A map of parameter names to string values that are parsed as | ||
| // SQL literal expressions. For example, map keys: "rank", "name", "birthdate"; | ||
| // map values: "1", "'Steven'", "DATE'2023-03-21'". The fragments of string values | ||
| // belonged to SQL comments are skipped while parsing. | ||
| map<string, string> args = 2; | ||
| // (Optional) A map of parameter names to literal expressions. | ||
| map<string, Expression.Literal> args = 2; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
| } | ||
|
|
||
| // Relation that reads from a file / table or other data source. Does not have additional | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at the doc, I think we should update it to include the new java datetime api like
LocalDate, and put then at the beginning to promote them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the PR #40644