Skip to content

[SPARK-42452][BUILD] Remove hadoop-2 profile from Apache Spark 3.5.0#40788

Closed
LuciferYang wants to merge 3 commits into
apache:masterfrom
LuciferYang:SPARK-42452
Closed

[SPARK-42452][BUILD] Remove hadoop-2 profile from Apache Spark 3.5.0#40788
LuciferYang wants to merge 3 commits into
apache:masterfrom
LuciferYang:SPARK-42452

Conversation

@LuciferYang

@LuciferYang LuciferYang commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This pr aims to remove hadoop-2 profile from Apache Spark 3.5.0.

Why are the changes needed?

Spark 3.4.0 no longer releases Hadoop2 binary distribtuion(SPARK-42447) and Hadoop 2 GitHub Action job already removed after SPARK-42447, we can remove hadoop-2 profile from Apache Spark 3.5.0.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

@LuciferYang LuciferYang marked this pull request as draft April 14, 2023 03:21
@LuciferYang LuciferYang changed the title [SPARK-42452][BUILD] Cleanup hadoop-2 profile [SPARK-42452][BUILD] Remove hadoop-2 profile from Apache Spark 3.5.0 Apr 14, 2023
@LuciferYang

Copy link
Copy Markdown
Contributor Author

Test first, need wait until 3.4 release at least

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @LuciferYang .

@dongjoon-hyun

Copy link
Copy Markdown
Member

Also, cc FYI, @sunchao

@bjornjorgensen

bjornjorgensen commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Test first, need wait until 3.4 release at least

3.4.0 is uploaded to mirrors.

@LuciferYang

Copy link
Copy Markdown
Contributor Author

Test first, need wait until 3.4 release at least

3.4.0 is uploaded to mirrors.

I know, but let's wait for the official website update

@LuciferYang LuciferYang marked this pull request as ready for review April 14, 2023 16:04
@sunchao

sunchao commented Apr 14, 2023

Copy link
Copy Markdown
Member

Personally I like this move, but not sure whether there are other users in the community that still depend on Hadoop 2.x. Has this been discussed before?

@bjornjorgensen

Copy link
Copy Markdown
Contributor

Personally I like this move, but not sure whether there are other users in the community that still depend on Hadoop 2.x. Has this been discussed before?

yes, like this one Dropping Apache Spark Hadoop2 Binary Distribution?

@sunchao

sunchao commented Apr 14, 2023

Copy link
Copy Markdown
Member

Oh cool, it's good then. Forgot about this thread even though I replied on it ..

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (from my side)

@sunchao

sunchao commented Apr 15, 2023

Copy link
Copy Markdown
Member

Just sent an email to the community in case anyone still have concerns on this.

@LuciferYang

Copy link
Copy Markdown
Contributor Author

friendly ping @dongjoon-hyun @sunchao

@sunchao sunchao closed this in 816ebac Apr 18, 2023
@sunchao

sunchao commented Apr 18, 2023

Copy link
Copy Markdown
Member

Merged to master, thanks!

@LuciferYang

Copy link
Copy Markdown
Contributor Author

Thanks @sunchao @dongjoon-hyun @bjornjorgensen ~

dongjoon-hyun added a commit that referenced this pull request Mar 25, 2024
### What changes were proposed in this pull request?

This PR aims to remove unused `commons-beanutils` dependency from `pom.xml` and `LICENSE-binary`.

### Why are the changes needed?

#30701 removed `commons-beanutils` from `hadoop-3` profile at Apache Spark 3.2.0.
- #30701

#40788 removed `hadoop-2` profile from Apache Spark 3.5.0
- #40788

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #45705 from dongjoon-hyun/SPARK-47548.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@LuciferYang LuciferYang deleted the SPARK-42452 branch March 30, 2026 08:08
dongjoon-hyun added a commit that referenced this pull request Jun 17, 2026
### What changes were proposed in this pull request?

This PR removes `Hadoop 3` from the GitHub Action workflow names.

### Why are the changes needed?

Apache Spark 3.5+ supports only Hadoop 3, so `Hadoop 3` is redundant in the workflow names in these days because Apache Spark 3.4 and older are EOL. All live branches are `Hadoop 3`.

- #40788

Note that this PR focuses only for GitHub Action workflow names, not a profile. We have kept the profile for the cases we need to split Hadoop distributions in a way. For example, hadoop-4 (although it doesn't exist yet) or hadoop-3.6 (if needed).

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

Generated-by: Claude Code

Closes #56576 from dongjoon-hyun/SPARK-57513.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants