[MINOR][PYTHON] Fix MyPy linter failure#41086
Closed
HyukjinKwon wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Not sure why this fails from a cursory look. MyPy version looks the same. Should be caused by either Python version or dependency of MyPy. |
Member
Author
|
Merged to master. |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
### What changes were proposed in this pull request? This PR adds a skip for the type check being failed in the build https://github.com/apache/spark/actions/runs/4910498665/jobs/8767736542 ``` starting mypy annotations test... annotations failed mypy checks: python/pyspark/broadcast.py:106: error: Overloaded function implementation does not accept all possible arguments of signature 3 [misc] Found 1 error in 1 file (checked 511 source files) ``` ### Why are the changes needed? To fix the broken build up. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? CI in this PR should verify them. Closes apache#41086 from HyukjinKwon/minor-typehint. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a skip for the type check being failed in the build https://github.com/apache/spark/actions/runs/4910498665/jobs/8767736542
Why are the changes needed?
To fix the broken build up.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
CI in this PR should verify them.