[SPARK-45767][CORE] Delete TimeStampedHashMap and its UT#43633
Closed
panbingkun wants to merge 3 commits into
Closed
[SPARK-45767][CORE] Delete TimeStampedHashMap and its UT#43633panbingkun wants to merge 3 commits into
TimeStampedHashMap and its UT#43633panbingkun wants to merge 3 commits into
Conversation
Contributor
Author
Contributor
Author
|
The issue of |
Contributor
|
I think the description of the PR should be clearer, like when this class was introduced, why it is no longer used, instead of referencing a comments. |
Contributor
Author
Done. |
LuciferYang
approved these changes
Nov 2, 2023
LuciferYang
left a comment
LuciferYang
left a comment
Contributor
There was a problem hiding this comment.
+1, LGTM if test pass
beliefer
approved these changes
Nov 2, 2023
Contributor
|
Merged into master for Spark 4.0. Thanks @panbingkun @dongjoon-hyun and @beliefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to delete
TimeStampedHashMapand its UT.Why are the changes needed?
During Pr #43578, we found that the class
TimeStampedHashMapis no longer in use. Based on the suggestion, we have removed it. #43578 (comment)TimeStampedHashMapbe introduced:b18d708#diff-77b12178a7036c71135074c6ddf7d659e5a69906264d5e3061087e4352e304ed introduced this data structure
TimeStampedHashMapis only being used in UTTimeStampedHashMapSuite.So, after Spark 3.0, this data structure has not been used by any production code of Spark.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.