Skip to content

[SPARK-47705][INFRA][FOLLOWUP] Sort LogKey alphabetically and build a test to ensure it#45864

Closed
panbingkun wants to merge 2 commits into
apache:masterfrom
panbingkun:fix_sort_logkey
Closed

[SPARK-47705][INFRA][FOLLOWUP] Sort LogKey alphabetically and build a test to ensure it#45864
panbingkun wants to merge 2 commits into
apache:masterfrom
panbingkun:fix_sort_logkey

Conversation

@panbingkun

@panbingkun panbingkun commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

The pr aims to fix bug about #45857

Why are the changes needed?

In fact, LogKey.values.toSeq.sorted did not sort alphabetically as expected.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • Pass GA.
  • Manually test.

Was this patch authored or co-authored using generative AI tooling?

No.

@panbingkun

Copy link
Copy Markdown
Contributor Author

cc @dtenedor @gengliangwang

@panbingkun

Copy link
Copy Markdown
Contributor Author

This UT did not achieve the goal we wanted to achieve,
I will add an automated tool that developers can use to automatically format it, just like:

/* Used to regenerate the error class file. Run:
{{{
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt \
"core/testOnly *SparkThrowableSuite -- -t \"Error classes are correctly formatted\""
}}}
To regenerate the error class document. Run:
{{{
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt \
"core/testOnly *SparkThrowableSuite -- -t \"Error classes match with document\""
}}}
*/

@dtenedor dtenedor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@gengliangwang

Copy link
Copy Markdown
Member

Thanks, merging to master

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants