[SPARK-46812][PYTHON][TESTS][FOLLOWUP] Check should_test_connect and pyarrow to skip tests#45880
Closed
dongjoon-hyun wants to merge 2 commits into
Closed
[SPARK-46812][PYTHON][TESTS][FOLLOWUP] Check should_test_connect and pyarrow to skip tests#45880dongjoon-hyun wants to merge 2 commits into
dongjoon-hyun wants to merge 2 commits into
Conversation
…pyarrow to skip tests
dongjoon-hyun
commented
Apr 4, 2024
|
|
||
|
|
||
| @unittest.skipIf(not have_pandas, pandas_requirement_message) | ||
| @unittest.skipIf(not should_test_connect, connect_requirement_message) |
Member
Author
There was a problem hiding this comment.
should_test_connect covers more edge cases than have_pandas.
dongjoon-hyun
commented
Apr 4, 2024
|
|
||
| @unittest.skipIf(not have_pandas, pandas_requirement_message) | ||
| @unittest.skipIf( | ||
| not have_pandas or not have_pyarrow, |
Member
Author
There was a problem hiding this comment.
This test has df.mapInArrow(lambda x: x, df.schema, False, rp).collect() too.
xinrong-meng
approved these changes
Apr 4, 2024
Member
|
LGTM thank you! |
Member
Author
|
Thank you, @xinrong-meng ! |
Member
Author
|
Merged to master. |
Member
Author
|
For the record, it's green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of SPARK-46812 to skip the tests more robustly and to recover PyPy CIs.
Why are the changes needed?
should_test_connectcovers more edge cases thanhave_pandas.test_resources.pyhas Arrow usage too.spark/python/pyspark/resource/tests/test_resources.py
Line 85 in 25fc67f
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tests with
pandasand withoutpyarrow.Was this patch authored or co-authored using generative AI tooling?
No.