[SPARK-47753][PYTHON][CONNECT][TESTS] Make pyspark.testing compatible with pyspark-connect#45916
Closed
HyukjinKwon wants to merge 2 commits into
Closed
[SPARK-47753][PYTHON][CONNECT][TESTS] Make pyspark.testing compatible with pyspark-connect#45916HyukjinKwon wants to merge 2 commits into
HyukjinKwon wants to merge 2 commits into
Conversation
HyukjinKwon
changed the title
zhengruifeng
approved these changes
Apr 7, 2024
Member
Author
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make
pyspark.testingcompatible withpyspark-connectby using noop context managercontextlib.nullcontextinstead ofQuietTestwhich requires JVM access.Why are the changes needed?
In order for
pyspark-connectto work without classic PySpark packages and dependencies. Also, the logs are hidden as it's written to the separate file so it is actually already quiet.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Yes, at #45870. Once CI is setup there, it will be tested there properly.
Was this patch authored or co-authored using generative AI tooling?
No.