Skip to content

[SPARK-47770][INFRA] Fix GenerateMIMAIgnore.isPackagePrivateModule to return false instead of failing #45938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 1 commit into from
Closed

[SPARK-47770][INFRA] Fix GenerateMIMAIgnore.isPackagePrivateModule to return false instead of failing #45938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,15 @@ object GenerateMIMAIgnore {
private def isPackagePrivate(sym: unv.Symbol) =
!sym.privateWithin.fullName.startsWith("<none>")

private def isPackagePrivateModule(moduleSymbol: unv.ModuleSymbol) =
private def isPackagePrivateModule(moduleSymbol: unv.ModuleSymbol) = try {
!moduleSymbol.privateWithin.fullName.startsWith("<none>")
} catch {
case e: Throwable =>
// scalastyle:off println
println("[WARN] Unable to check module:" + moduleSymbol)
// scalastyle:on println
false
}

/**
* For every class checks via scala reflection if the class itself or contained members
Expand Down