[SPARK-47413][SQL] - add support to substr/left/right for collations [Post-Refactor]#46039
Closed
GideonPotok wants to merge 5 commits into
Closed
[SPARK-47413][SQL] - add support to substr/left/right for collations [Post-Refactor]#46039GideonPotok wants to merge 5 commits into
GideonPotok wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-46830
What changes were proposed in this pull request?
Add collation support to types of return values for calls to substr, left, right, when passed in arguments of an explicit, implicit, or session-specified collations. Add tests to validate behavior.
Why are the changes needed?
We are incrementally adding collation support to built-in string functions in Spark. These functions are intended to be supported for collated types.
Does this PR introduce any user-facing change?
these sql functions will now not throw errors when passed in collated types. Instead, they will return the right value, of the passed in type. Or of the default collation.
How was this patch tested?
Unit testing + ad-hoc spark shell and pyspark shell interactions.
Was this patch authored or co-authored using generative AI tooling?
No.