[SPARK-48054][PYTHON][CONNECT][INFRA] Backward compatibility test for Spark Connect#46298
[SPARK-48054][PYTHON][CONNECT][INFRA] Backward compatibility test for Spark Connect#46298HyukjinKwon wants to merge 12 commits into
Conversation
|
A basic question about the "backward compatibility" policy: does it mean that the user can
|
|
For now, I am testing old client -> newer server case only. |
|
@pan3793 - user must use a lower (or same) version client to connect to a server ONLY. |
nija-at
left a comment
There was a problem hiding this comment.
Overall LGTM. Consider the minor comments above.
make sense, would be great to clarify that on the docs :) |
b9498ff to
ac4d2d1
Compare
ac4d2d1 to
b00b659
Compare
|
For notes to my self: Tests being skipped for now |
2036352 to
1ee91df
Compare
|
Doctest: |
aa0bd35 to
e8c0bba
Compare
b6ce491 to
31ec47e
Compare
881bd0a to
15ef1d3
Compare
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 21 * * *' |
There was a problem hiding this comment.
Thank you. Ya, +1 for adding this and this looks not a heavy.
After adding this, please monitor once if it works expected in the total budget.
There was a problem hiding this comment.
Thanks for the pointer!
|
Merged to master. |
…5 client <> 4.0 server ### What changes were proposed in this pull request? This PR proposes to skip the tests that fail with 3.5 client and 4.0 server in Spark Connect (by adding `SPARK_SKIP_CONNECT_COMPAT_TESTS`). This is a base work for #46298. This partially backports #45870 This PR also adds `SPARK_CONNECT_TESTING_REMOTE` environment variable so developers can run PySpark unittests against a Spark Connect server. ### Why are the changes needed? In order to set up the CI that tests 3.5 client and 4.0 server in Spark Connect. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Tested it in my fork, see #46298 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46334 from HyukjinKwon/SPARK-48088. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
…to SPARK_SKIP_CONNECT_COMPAT_TESTS ### What changes were proposed in this pull request? This PR is a followup of #46298 that properly uses the environment variable SPARK_SKIP_CONNECT_COMPAT_TESTS added at #46334 ### Why are the changes needed? To recover the compatibility test (https://github.com/apache/spark/actions/runs/8961109352/job/24608366499). ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46394 from HyukjinKwon/SPARK-48054-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR is a tentative try to run Spark 3.5 tests with Python Client 3.5 against Spark Connect server 4.0.
Why are the changes needed?
In order to make sure the compatibility between 3.5 and 4.0.
Does this PR introduce any user-facing change?
No, testing-only.
How was this patch tested?
Within my own fork.
Was this patch authored or co-authored using generative AI tooling?
No.